New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: clarify how the limit
option works
#13985
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just to check; do we have tests for these three examples to ensure that's the actual behavior?
We test for There is also an undocumented |
I've removed the third example I added as it's an unrelated limit option (Includable.limit) with a different behavior. I've also piggybacked this tiny PR to document a weirdness I found in operators.ts (registering operators in the global symbol registry). |
Could you add tests for this? |
Sounds good, I'll look into it :) |
Test added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Woops, was too early with the approval. Do fix the mssql assertion first
That's weird. Why does mssql produce it doesn't seem to be doing that in other queries or when Ok so |
Ok it should be fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, any idea if/when you want to address those TODOs?
Not in this PR but we'll eventually get to it as we migrate to TS |
🎉 This PR is included in version 7.0.0-alpha.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Pull Request Checklist
npm run test
ornpm run test-DIALECT
pass with this change (including linting)?Description Of Change
I'm attempting to clarify what
FindOptions#limit
does and its interaction withFindOptions#subQuery
Related to #9605